fix: Sets cache support to false, removes upper req limit#499
Merged
chalmerlowe merged 4 commits intomainfrom Nov 10, 2022
Merged
fix: Sets cache support to false, removes upper req limit#499chalmerlowe merged 4 commits intomainfrom
chalmerlowe merged 4 commits intomainfrom
Conversation
Collaborator
Author
|
20221025: |
Collaborator
Author
|
20221104: there is a prerelease issue with parsing the sqlalchemy version number. |
Collaborator
Author
parthea
approved these changes
Nov 10, 2022
atkincaid74
added a commit
to KoffieLabs/python-bigquery-sqlalchemy
that referenced
this pull request
Dec 19, 2022
Revert "docs: fix changelog header to consistent size (googleapis#461)" This reverts commit 177e70a. Revert "chore: test minimum dependencies in python 3.7 (googleapis#463)" This reverts commit acc9274. Revert "chore(main): release 1.4.4 (googleapis#462)" This reverts commit 06c0270. Revert "fix: require python 3.7+ (googleapis#468)" This reverts commit 52ec808. Revert "chore(python): fix prerelease session [autoapprove] (googleapis#476)" This reverts commit e894dfa. Revert "chore: add hashes to requirements.txt' (googleapis#483)" This reverts commit cc13fe3. Revert "chore(python): exclude `grpcio==1.49.0rc1` in tests (googleapis#484)" This reverts commit 484d524. Revert "ci(python): fix path to requirements.txt in release script (googleapis#485)" This reverts commit 4f90d90. Revert "chore(python): update .kokoro/requirements.txt (googleapis#486)" This reverts commit 4b37fed. Revert "chore(python): exclude setup.py in renovate config (googleapis#487)" This reverts commit 9ffc736. Revert "chore(deps): update all dependencies (googleapis#488)" This reverts commit 189af9b. Revert "chore: detect samples tests in nested directories (googleapis#492)" This reverts commit f566371. Revert "feat: Allow Users to Supply Their Own BigQuery Client (googleapis#474)" This reverts commit 4f72d4e. Revert "chore: update dependency protobuf >= 3.20.2 (googleapis#498)" This reverts commit f188944. Revert "fix: Sets cache support to false, removes upper req limit (googleapis#499)" This reverts commit be63adc. Revert "fix: updates test to account for UTC in failing test (googleapis#501)" This reverts commit a050ccf. Revert "fix(deps): allow pyarrow version 7+ (googleapis#479)" This reverts commit 0f6be67. Revert "fix: use packaging version parser instead of string splitting (googleapis#513)" This reverts commit bb7f6a7. Revert "chore(main): release 1.5.0 (googleapis#469)" This reverts commit 1ffab57. Revert "chore: addressed lint issue with __version__ (googleapis#534)" This reverts commit 4e17259. Revert "build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /synthtool/gcp/templates/python_library/.kokoro (googleapis#535)" This reverts commit 57794c3.
atkincaid74
added a commit
to KoffieLabs/python-bigquery-sqlalchemy
that referenced
this pull request
Mar 16, 2023
Revert "docs: fix changelog header to consistent size (googleapis#461)" This reverts commit 177e70a. Revert "chore: test minimum dependencies in python 3.7 (googleapis#463)" This reverts commit acc9274. Revert "chore(main): release 1.4.4 (googleapis#462)" This reverts commit 06c0270. Revert "fix: require python 3.7+ (googleapis#468)" This reverts commit 52ec808. Revert "chore(python): fix prerelease session [autoapprove] (googleapis#476)" This reverts commit e894dfa. Revert "chore: add hashes to requirements.txt' (googleapis#483)" This reverts commit cc13fe3. Revert "chore(python): exclude `grpcio==1.49.0rc1` in tests (googleapis#484)" This reverts commit 484d524. Revert "ci(python): fix path to requirements.txt in release script (googleapis#485)" This reverts commit 4f90d90. Revert "chore(python): update .kokoro/requirements.txt (googleapis#486)" This reverts commit 4b37fed. Revert "chore(python): exclude setup.py in renovate config (googleapis#487)" This reverts commit 9ffc736. Revert "chore(deps): update all dependencies (googleapis#488)" This reverts commit 189af9b. Revert "chore: detect samples tests in nested directories (googleapis#492)" This reverts commit f566371. Revert "feat: Allow Users to Supply Their Own BigQuery Client (googleapis#474)" This reverts commit 4f72d4e. Revert "chore: update dependency protobuf >= 3.20.2 (googleapis#498)" This reverts commit f188944. Revert "fix: Sets cache support to false, removes upper req limit (googleapis#499)" This reverts commit be63adc. Revert "fix: updates test to account for UTC in failing test (googleapis#501)" This reverts commit a050ccf. Revert "fix(deps): allow pyarrow version 7+ (googleapis#479)" This reverts commit 0f6be67. Revert "fix: use packaging version parser instead of string splitting (googleapis#513)" This reverts commit bb7f6a7. Revert "chore(main): release 1.5.0 (googleapis#469)" This reverts commit 1ffab57. Revert "chore: addressed lint issue with __version__ (googleapis#534)" This reverts commit 4e17259. Revert "build(deps): bump certifi from 2022.9.24 to 2022.12.7 in /synthtool/gcp/templates/python_library/.kokoro (googleapis#535)" This reverts commit 57794c3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
supports_statement_cachetoFalseAt this time, it is not yet clear whether BigQuery, out of the box, supports SQL statement caching. In an effort to clear the failing tests and allow interoperability with sqlalchemy > 1.4.27, we are opting to provide these limited changes while additional work is pursued to confirm that BigQuery connector libraries and APIs support statement caching.
Fixes #385 🦕
A follow on issue (TODO: add issue number here), will be submitted prior to closing this PR to ensure that resources are applied to confirming statement caching support.
TODO add a comment to the code regarding the
supports_statement_cache = Falsepurpose and next steps.